Update scss grammar file to fix those tickets: #8636, #8686 and #5799#9365
Merged
Chris2011 merged 1 commit intoapache:masterfrom Apr 26, 2026
Merged
Conversation
Chris2011
added
CSS
Contributor
|
Seems good for me. |
haidubogdan
approved these changes
Apr 25, 2026
matthiasblaesing
approved these changes
Apr 26, 2026
Contributor
matthiasblaesing
left a comment
matthiasblaesing
left a comment
There was a problem hiding this comment.
Only eyeballed this, but I agree with @haidubogdan and it makes sense to me. Thank you.
Member
|
you have to link the issues with the PR so that they close when the PR is merged to master. Otherwise we might forget about them and they could stay open. |
Contributor
Author
|
Thx for the hint, will do it next time. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a couple of missing scss grammar featues:
#5799, #8636 and #8686
There are some syntax features that were missing in the current Css3.g (CSS, SASS/SCSS and LESS) grammar file.
I thought about of making multiple PRs instead of one, but those are small, I would say. But I'm fine to decouple them.
If this PR targets the delivery branch: don't merge. (full wiki article)